Skip to content

bench: refactor to use string interpolation in ndarray/base/copy#11037

Closed
parthodas23 wants to merge 1 commit intostdlib-js:developfrom
parthodas23:rfc/ndarray-base-copy
Closed

bench: refactor to use string interpolation in ndarray/base/copy#11037
parthodas23 wants to merge 1 commit intostdlib-js:developfrom
parthodas23:rfc/ndarray-base-copy

Conversation

@parthodas23
Copy link
Contributor

@parthodas23 parthodas23 commented Mar 19, 2026 •
edited
Loading

Progresses #8647 .

Description

What is the purpose of this pull request?

This pull request:

  • bench: refactor to use string interpolation in ndarray/base/copy

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Mar 19, 2026
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 19, 2026

Hello! 👋

We've noticed that you've been opening a number of PRs addressing good first issues. Thank you for your interest and enthusiasm!

Now that you've made a few contributions, we suggest no longer working on good first issues. Instead, we encourage you to prioritize cleaning up any PRs which have yet to be merged and then proceed to work on more involved tasks.

Not only does this ensure that other new contributors can work on things and get ramped up on all things stdlib, it also ensures that you can spend your time on more challenging problems. 🚀

For ideas for future PRs, feel free to search the codebase for TODOs and FIXMEs and be sure to check out other open issues on the issue tracker. Cheers!

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 19, 2026

Coverage Report

Package Statements Branches Functions Lines
ndarray/base/copy $\color{green}97/97$
$\color{green}+100.00%$ 		$\color{green}3/3$
$\color{green}+100.00%$ 		$\color{green}1/1$
$\color{green}+100.00%$ 		$\color{green}97/97$
$\color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Benchmarks Pull requests adding or improving benchmarks for measuring performance. review: 5 and removed Needs Review A pull request which needs code review. labels Mar 20, 2026
kgryte
kgryte requested changes Mar 20, 2026
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not desired. The use of format in this description is unnecessary. Closing.

@kgryte kgryte added review: 1 Invalid Invalid question, issue, or pull request. and removed review: 5 labels Mar 20, 2026
@kgryte kgryte closed this Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte requested changes

Assignees

No one assigned

Labels

Benchmarks Pull requests adding or improving benchmarks for measuring performance. difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Good First PR A pull request resolving a Good First Issue. Invalid Invalid question, issue, or pull request. review: 1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@parthodas23 @stdlib-bot @kgryte